Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hydraulic unit fix ups #416

Merged
merged 3 commits into from
Jan 13, 2025
Merged

hydraulic unit fix ups #416

merged 3 commits into from
Jan 13, 2025

Conversation

BenTWhite
Copy link
Contributor

  1. fixed the length_short formatter to use mm and inches
  2. added an infiltration_intensity formatter for rainfall intensity
  3. added a side slope formatter which uses the inverted slope unit - for the side slopes trapezoidal channels along with some coming attributes associated with storage

@BenTWhite BenTWhite requested review from a team as code owners January 7, 2025 15:52
@BenTWhite BenTWhite enabled auto-merge (squash) January 7, 2025 15:57
@BenTWhite
Copy link
Contributor Author

@ColinKerr @naveedkhan8067 @diegoalexdiaz

the IModelNativeTests are failing - not sure what is happening. Let me know if it is something on my side.

image

@naveedkhan8067
Copy link
Collaborator

@ColinKerr @naveedkhan8067 @diegoalexdiaz

the IModelNativeTests are failing - not sure what is happening. Let me know if it is something on my side.

image

@BenTWhite , its not because of your changes. There is a PR on imodel-native side that got merge and its relevant changes on iTwin.js side are still waiting. As soon as that PR merge these tests should pass.

@diegoalexdiaz diegoalexdiaz added the OpenSite+ Pull requests aimed at OpenSite+ timeline. label Jan 10, 2025
@naveedkhan8067
Copy link
Collaborator

/azp run iModelNativeTests

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@naveedkhan8067
Copy link
Collaborator

@ColinKerr @naveedkhan8067 @diegoalexdiaz
the IModelNativeTests are failing - not sure what is happening. Let me know if it is something on my side.
image

@BenTWhite , its not because of your changes. There is a PR on imodel-native side that got merge and its relevant changes on iTwin.js side are still waiting. As soon as that PR merge these tests should pass.

@BenTWhite, it should be working now.

@BenTWhite
Copy link
Contributor Author

@naveedkhan8067

Just a heads up - am getting this failure message:

src/BriefcaseManager.ts(439,19): error TS2554: Expected 2 arguments, but got 1.

@naveedkhan8067
Copy link
Collaborator

/azp run iModelNativeTests

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@BenTWhite BenTWhite merged commit 23cbcf3 into master Jan 13, 2025
18 checks passed
@BenTWhite BenTWhite deleted the unit-fix-ups branch January 13, 2025 09:30
@naveedkhan8067
Copy link
Collaborator

Just a heads up

Seems like iTwin.js build was broken for some time due to another issue as well. I have retriggered the build and it has passed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ColinKerr ColinKerr ColinKerr left review comments

@diegoalexdiaz diegoalexdiaz diegoalexdiaz approved these changes

Assignees
No one assigned
Labels
OpenSite+ Pull requests aimed at OpenSite+ timeline.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BenTWhite @naveedkhan8067 @ColinKerr @diegoalexdiaz